Adds newly available GCF regions. #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
reviewed
Jul 7, 2020
| 'us-central1', | ||
| 'us-east1', | ||
| 'us-east4', | ||
| 'us-west3', |
Contributor
There was a problem hiding this comment.
Now that GCF supports so many region could we consider changing the invalid region check from an error to a warning? That way we don't have to keep chasing this list.
We can link people to this page from the warning:
https://cloud.google.com/functions/docs/locations
Contributor
Author
There was a problem hiding this comment.
I'm not actually going to have it error or warn anymore. The supported regions will just be a TypeScript hinting convenience, and in a followup I think we should have the CLI do a live check against the locations API instead.
samtstern
approved these changes
Jul 7, 2020
laurenzlong
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code sample